Add radius to DO_REPOSITION #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
upstream PR mavlink#1787 |
|
I've discussed this with @WickedShell who's in favor of it. |
magicrub
force-pushed
the
do_reposition_radius
branch
from
df2833c
to
cd04d3b
Compare
|
I'm having second thoughts about this. Would probably be better to just use a new enum entry in MAV_DO_REPOSITION_FLAGS to say radius is included and overrides the yaw value for planes |
magicrub
force-pushed
the
do_reposition_radius
branch
from
cd04d3b
to
4e5b903
Compare
|
I've updated the upstream PR mavlink#1825 |
magicrub
force-pushed
the
do_reposition_radius
branch
from
4e5b903
to
003c6a7
Compare
|
This was discussed at the mavlink dev call per comment mavlink#1825 (comment) and the upstream PR was updated. I'll make an ardupilot/ardupilot PR but we don't necessarily need to update mavlink quite yet. It's just utilizing an existing unused param3 |
|
Ardupilot implementation: ArduPilot/ardupilot#19860 |
|
upstream merged mavlink#1825 |
|
can someone please merge this |
peterbarker
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Radius to CMD_DO_REPOSIITON for better atomic operations of control on guided commands. It uses language from the other CMD_NAV_LOITER commands