Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add radius to DO_REPOSITION v2 #1825

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Add radius to DO_REPOSITION v2 #1825

merged 1 commit into from
Apr 10, 2022

Conversation

magicrub
Copy link
Contributor

This replaces #1787

Add radius, and a bit flag to utilize it, to DO_REPOSITION so it's much more useful for planes in guided modes

See ArduPilot#240 for a matching Ardupilot/mavlink PR

@magicrub magicrub mentioned this pull request Mar 28, 2022
Merged
@hamishwillee
Copy link
Collaborator

I deleted a couple of old messages, which you can ignore.
We discussed in dev call.

  • Please remove MAV_DO_REPOSITION_FLAGS_USE_RADIUS flag.
  • Continue to use yaw for direction in plane.
  • Radius is used on plane if it is a positive number. If it is zero it should be ignored.

That's cleaner.

@hamishwillee
Copy link
Collaborator

@magicrub Thoughts?

@magicrub
Copy link
Contributor Author

magicrub commented Apr 6, 2022

If you think that's the lesser evil, fine by me. I'll update.

@magicrub magicrub force-pushed the do_reposition_radius_upstream branch from f33ab88 to c2b0723 Compare April 7, 2022 22:58
@magicrub
Copy link
Contributor Author

magicrub commented Apr 7, 2022

@hamishwillee updated

@magicrub magicrub mentioned this pull request Apr 8, 2022
Closed
@magicrub
Copy link
Contributor Author

magicrub commented Apr 9, 2022

ArduPilot implementation PR: ArduPilot/ardupilot#19860

hamishwillee
hamishwillee approved these changes Apr 10, 2022
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Merging as this is non-breaking and is as agreed in last dev call.

@hamishwillee hamishwillee merged commit 56a5110 into mavlink:master Apr 10, 2022
@magicrub magicrub deleted the do_reposition_radius_upstream branch April 10, 2022 00:29
@magicrub magicrub mentioned this pull request Apr 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magicrub @hamishwillee