-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
common.xml: remove wip from AIS_VESSEL #1817
Conversation
Thanks @peterbarker There are also a whole bunch of enums associated with this -e.g. I'll make sure there are no objections in dev call tonight. |
From devcall - we're trying to stick with the governance model proposal of only "formally" including things in common.xml that are in one stack and with "firm intent" to get in another stack. We think this fits that model - just trying to confirm that this either is or will be supported by MAVSDK as well in the near future. @julianoes @bazfp - can you confirm? |
Fair enough. As an alternative we could move it into |
@julianoes @bazfp - can you confirm #1817 (comment) Thanks @peterbarker - I think would be good to get into common, we're just trying to 'do the right thing". Either way though, this can't be merged until the associated enums are also updated to remove the "Wip comments". |
I have firm intent to get USV features like AIS features into our autonomy + MAVSDK |
AIS is below some more crucial changes, but may jump up as we have discussed including this on a recent vehicle |
Yup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed merge in devcall based on normal rule of "in one stack" and commitment to get in another.
This one has cooked long enough...