Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common.xml: remove wip from AIS_VESSEL #1817

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

peterbarker
Copy link
Contributor

This one has cooked long enough...

@hamishwillee
Copy link
Collaborator

hamishwillee commented Mar 16, 2022

Thanks @peterbarker

There are also a whole bunch of enums associated with this -e.g. AIS_FLAGS that have informal wip markup - you can see them in #1228
Can you also tidy those?

I'll make sure there are no objections in dev call tonight.

@hamishwillee
Copy link
Collaborator

From devcall - we're trying to stick with the governance model proposal of only "formally" including things in common.xml that are in one stack and with "firm intent" to get in another stack. We think this fits that model - just trying to confirm that this either is or will be supported by MAVSDK as well in the near future. @julianoes @bazfp - can you confirm?

@peterbarker
Copy link
Contributor Author

From devcall - we're trying to stick with the governance model proposal of only "formally" including things in common.xml that are in one stack and with "firm intent" to get in another stack. We think this fits that model - just trying to confirm that this either

Fair enough. As an alternative we could move it into ardupilotmega.xml.

@hamishwillee
Copy link
Collaborator

@julianoes @bazfp - can you confirm #1817 (comment)

Thanks @peterbarker - I think would be good to get into common, we're just trying to 'do the right thing". Either way though, this can't be merged until the associated enums are also updated to remove the "Wip comments".

@bazfp
Copy link

bazfp commented Mar 23, 2022

From devcall - we're trying to stick with the governance model proposal of only "formally" including things in common.xml that are in one stack and with "firm intent" to get in another stack. We think this fits that model - just trying to confirm that this either is or will be supported by MAVSDK as well in the near future. @julianoes @bazfp - can you confirm?

I have firm intent to get USV features like AIS features into our autonomy + MAVSDK

@hamishwillee
Copy link
Collaborator

Thanks @bazfp - sounds great. FMI, any timeframe in mind?

@auturgy You OK to merge? This is good enough for me.

@bazfp
Copy link

bazfp commented Mar 24, 2022

Thanks @bazfp - sounds great. FMI, any timeframe in mind?

AIS is below some more crucial changes, but may jump up as we have discussed including this on a recent vehicle

@auturgy
Copy link
Collaborator

auturgy commented Mar 24, 2022

merge

Yup

Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed merge in devcall based on normal rule of "in one stack" and commitment to get in another.

@hamishwillee hamishwillee merged commit d5b9709 into mavlink:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants