MAV_TYPE_VTOL _DUOROTOR and _QUADROTOR renamed to new format #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI @sfuhrer @auturgy @meee1 Don is happy to force all users of these enum values to update next time they do a rebuild (though in no way requiring them to do a rebuild). I think this is fine and I would like to do this. Anyway this is an FYI to give you a chance to agree/disagree on behalf of our respective communities. |
|
This has also been agreed/approved by @auturgy (offline). Merging. @meee1 @DonLakeFlyer Note the break on next compile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR update the names of the enum values:
MAV_TYPE_VTOL_DUOROTORtoMAV_TYPE_VTOL_TAILSITTER_DUOROTORMAV_TYPE_VTOL_QUADROTORtoMAV_TYPE_VTOL_TAILSITTER_QUADROTORThis update matches the values to the naming convention discussed in #1808 (comment)
The change follows on from #1808 and in particular the discussion https://github.com/mavlink/mavlink/pull/1808/files#r823318681
It is in a separate PR because anyone who uses these values will need to update their code on next build with new library. Note however that code that is not rebuilt will continue to work (the change is forward compatible.