simulator_mavlink: remove MAV_TYPE_VTOL_TAILSITTER case #19711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type (23) doesn't specify a motor number, so it can't be properly handled. There are duo (19) and quad (20) tailsitter types that still work in simulation. Signed-off-by: Silvan Fuhrer <silvan@auterion.com>
sfuhrer
changed the title
dagar
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This type (23) doesn't specify a motor number, so it can't be properly handled. For sure not with 3 motors. This came in when we renamed some VTOL_RESERVED types in mavlink/mavlink#1818.
There are duo (19) and quad (20) tailsitter types that still work in simulation.
Note: as soon as we switch to the new allocation architecture we don't need MAV_TYPE for the motor simulation anymore.