Gimbal manager: Add gimbal device flags to low word of gimbal manager flags #1928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me - @julianoes assigned to you because it is gimblish :-) |
|
This is now failing due to GIMBAL_DEVICE_CAP_FLAGS_SUPPORTS_YAW_IN_EARTH_FRAME, etc duplication. The status check on this PR caught the failure. https://github.com/mavlink/mavlink/actions/runs/3581910723/jobs/6025516683
|
This was referenced Dec 7, 2022
|
omg ... my fault, sorry guys |
TSC21
pushed a commit
to Dronecode/air-iop-definitions
that referenced
this pull request
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lower 16 bits of the gimbal manager flags and cap flags are supposed to coincide the gimbal device flags and cap flags. This PR aligns the manager flags & cap flags with the recent additions to the gimbal device flags & cap flags. I have also added .'s in the descriptions of the gimbal manager flags, as it's so in the descriptions of the gimbal manager cap flags.