Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix / suppress some build warnings #1865

Merged
merged 3 commits into from
Jun 12, 2023
Merged

Fix / suppress some build warnings #1865

merged 3 commits into from
Jun 12, 2023

Conversation

mortenfyhn
Copy link
Contributor

@mortenfyhn mortenfyhn commented Jun 12, 2023 •
edited
Loading

Hi all, this does three things:

  • Use the cmake SYSTEM option to have it consider 3rd party library headers as system headers, and thus not emit build warnings from them.
  • Fix some build warnings in mavros_extras.
  • Remove unneeded trailing semicolon on some namespace declarations.

Feel free to use this if it's useful for you.

vooon
vooon approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@vooon vooon added this to the Version 1.17 milestone Jun 12, 2023
@vooon vooon merged commit 4a8cd45 into mavlink:master Jun 12, 2023
@mortenfyhn mortenfyhn deleted the warnings branch June 12, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 1.17
Development

Successfully merging this pull request may close these issues.
2 participants
@mortenfyhn @vooon