Camera IMU synchronisation support added #312
Conversation
|
|
||
| bool trigger_control_cb(mavros::CommandTriggerControl::Request &req, | ||
| mavros::CommandTriggerControl::Response &res) { | ||
| return send_command_long_and_wait(MAV_CMD_DO_TRIGGER_CONTROL, (req.trigger_enable)? 1.0 : 0.0, |
There was a problem hiding this comment.
You passed param1 to confirmation argument!
|
About python parser, read documentation: https://docs.python.org/2.7/library/argparse.html Service proxy moved here: mavros.command |
|
@vooon Some help needed : What's going on here? I can't find the referred logs to track down what goes wrong. |
|
Hmm, usually i don't see ACK from PX4 at all. |
|
@mhkabir Does your issue with the rejected command persist? I saw a commit on the Firmware side which should resolve this. |
|
@LorenzMeier Yes, this persists. I had applied the "commander ignore" commit when testing this. No error / reject message comes in via mavlink log though. |
|
@mhkabir status now? |
|
@vooon No luck. Can you have a look? Latest PX4 master has the trigger app, but mavros still fails. |
|
Now i'm going to reassembly my plane, so can't test master right now. |
Camera IMU synchronisation support added
|
For me this PR looks good. Reject seems related to Firmware side, so i merge as is. |
@vooon Please review. Don't merge yet.
Also, I'm unable to figure out how the python mavcmd script argument parsing works, so I couldn't edit it to add the command sending. Can you please add that or tell me how? Or maybe @TSC21 is interested?
PX4 pull is here : PX4/PX4-Autopilot#2207