Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge gps and global_position plugins #325

Closed
vooon opened this issue Jul 2, 2015 · 10 comments
Closed

Merge gps and global_position plugins #325

vooon opened this issue Jul 2, 2015 · 10 comments

Comments

@vooon
Copy link
Member

vooon commented Jul 2, 2015

I think we may merge that plugins, because their output needed for one purpose: provide global position data.

@TSC21
Copy link
Member

TSC21 commented Jul 2, 2015

Seems good. Assign that task to me, if you may

@vooon
Copy link
Member Author

vooon commented Jul 2, 2015

First we need to discus proposal.

@TSC21
Copy link
Member

TSC21 commented Jul 2, 2015

What do you have in mind?

@vooon
Copy link
Member Author

vooon commented Jul 2, 2015

Past versions of APM don't send fused global position, so for that old firmwares blacklisting global_position may save little ram.
But those plugins are coupled, because gp can't properly work without gps.

So in one hand i have splitted raw and fused data and possibility to disable fused part
and in other e.g. apm antenna tracker uses only fused coordinates.

@TSC21
Copy link
Member

TSC21 commented Jul 2, 2015

You can use #if #endif clauses depending on the autopilot. So then you can keep the plugin active. What do you think?

@vooon
Copy link
Member Author

vooon commented Jul 2, 2015

Compile time option not useful, ros buildfarm cant produce several packages with different compile time options.

Currently ros binaries uses APM's dialect, but because almost all used messages exists in common PX4 don't require special binary.

@TSC21
Copy link
Member

TSC21 commented Jul 2, 2015

So we can add a parameter is_raw, which when set publishes on raw gps, but when not set publishes filtered position.

@vooon
Copy link
Member Author

vooon commented Jul 2, 2015

No, stream raw and fused, just like imu_pub.

@TSC21
Copy link
Member

TSC21 commented Jul 2, 2015

At the same time but for different topics, right? Seems legit then.

@vooon
Copy link
Member Author

vooon commented Jul 2, 2015

Merge is done. GPS raw topics now in ~global_position/raw, and we moved to TF2.
Also parameters changed, tf things moved to tf subnamespace.

@vooon vooon closed this as completed Jul 2, 2015
@vooon vooon mentioned this issue Jul 21, 2015
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants