Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move visualization plugin to node #336

Closed
vooon opened this issue Jul 9, 2015 · 5 comments
Closed

Move visualization plugin to node #336

vooon opened this issue Jul 9, 2015 · 5 comments
Labels
extras plugin testing required
Milestone
Version 0.16

Comments

@vooon
Copy link
Member

vooon commented Jul 9, 2015

As i see viz only wants local position, so why not move that code to node?
I think that was more usable because since extraction you not need to copy-paste local_position code
and may restart viz at any time.

Ping @mhkabir
@vooon vooon mentioned this issue Jul 9, 2015
Closed
14 tasks
@mhkabir
Copy link
Member

mhkabir commented Jul 10, 2015

@vooon sounds good! There is a slight issue with the markers not displaying sometimes, which we need to find and fix as well.

vooon added a commit that referenced this issue Jul 10, 2015
@vooon
extras: viz #336: convert plugin to node.
61cc2fe
@vooon
Copy link
Member Author

vooon commented Jul 10, 2015

@mhkabir i'm done, now testing required.

@mhkabir
Copy link
Member

mhkabir commented Jul 10, 2015

@vooon Awesome. Can you see the marker in RViz? Can you give it a try, because I don't have my copter around ATM.

@TSC21
Copy link
Member

TSC21 commented Jul 10, 2015

@mhkabir why don't you try with ROS SITL?

TSC21 pushed a commit to TSC21/mavros that referenced this issue Jul 10, 2015
@vooon @TSC21
extras: viz mavlink#336: convert plugin to node.
6d08af4
TSC21 pushed a commit to TSC21/mavros that referenced this issue Jul 10, 2015
@vooon @TSC21
extras: viz mavlink#336: convert plugin to node.
30a7fe6
vooon added a commit that referenced this issue Jul 10, 2015
@vooon
Merge branch 'master' into verbcast
6e2a39f 
* master:
  fix #71: replace depend tf to tf2_ros.
  extras: distance_sensor #71: Purt to TF2.
  plugin: Use UAS::syncronized_header() for reduce LOC.
  lib #319: use similar names for covariances as eigen vector
  lib #319: transform_frame() for Covariance3x3
  lib #319: remove unused bullet based transform_frame()
  extras: vision_pose #71: Use TF2 listener.
  plugin #71: Implement TF2 listener. Change param names.
  uas #71: Use single TF2 objects for broadcasting and subscription.
  launch: Update configs.
  extras: viz #336: convert plugin to node.
  lib: Add UAS::quaternion_to_rpy()
  extras: vision_speed #319: use eigen based transform
  extras: vibration: Use UAS::synchronized_header()
  extras: px4flow #319: change transform_frame()
  extras: mocap #319: use eigen based transform
  plugin: safety_area #319: Change transform_frame()
  plugin: local_position #71 #319: port to TF2 and Eigen
  lib: Add UAS::synchonized_header()
  plugin: command: Add command broadcasting support.
TSC21 pushed a commit to TSC21/mavros that referenced this issue Jul 12, 2015
@vooon @TSC21
extras: viz mavlink#336: convert plugin to node.
f20d0db
@vooon
Copy link
Member Author

vooon commented Oct 21, 2015

I checked RViz with some bag file.

For some time it works, but later stops, when node still produce new markers.
Also changing origin frame break viz.

So it works, but URDF+Mesh definitely better.

@vooon vooon closed this as completed Oct 21, 2015
@vooon vooon added this to the Version 0.16 milestone Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
extras plugin testing required
Projects
None yet
Milestone
Version 0.16
Development

No branches or pull requests
3 participants
@vooon @TSC21 @mhkabir