Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add frame transform for vibration levels #690

Merged
merged 3 commits into from
Apr 9, 2017
Merged

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented Apr 6, 2017

NED to ENU

@TSC21 TSC21 changed the title Add frame transform for accel vibration levels Add frame transform for vibration levels Apr 6, 2017
@TSC21
Copy link
Member Author

TSC21 commented Apr 6, 2017

On the FCU side though, PX4/PX4-Autopilot@a516450#diff-e605251d3710c0f7f0c065b242004e9cR1486 - maybe extend the msg to include the accel clipping by applying a FFT to the signals and compare with clear ones. @LorenzMeier any thoughts?

vibe_msg->clipping[1] = vibration.clipping_1;
vibe_msg->clipping[2] = vibration.clipping_2;
vibe_msg->clipping[1] = vibration.clipping_1;
vibe_msg->clipping[2] = vibration.clipping_2;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting looks off.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot to uncrustify. thanks

@TSC21
Copy link
Member Author

TSC21 commented Apr 8, 2017

@vooon, @mhkabir lgtm?

@TSC21 TSC21 requested a review from vooon April 9, 2017 04:06
@vooon vooon merged commit 89c8704 into mavlink:master Apr 9, 2017
@TSC21 TSC21 deleted the vibration_tft branch April 9, 2017 18:37
vooon pushed a commit that referenced this pull request Apr 20, 2017
* add frame transform for accel vibration levels

* use vectorEigenToMsg

* unscrustify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants