Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance sensors improvements #740

Closed
khancyr opened this issue Jun 21, 2017 · 10 comments
Closed

Distance sensors improvements #740

khancyr opened this issue Jun 21, 2017 · 10 comments

Comments

@khancyr
Copy link
Contributor

khancyr commented Jun 21, 2017

FEATURE details

Can be assign to me !

@TSC21
Copy link
Member

TSC21 commented Jun 21, 2017

Add support for laser subscriber and publisher

You mean: http://docs.ros.org/api/sensor_msgs/html/msg/LaserScan.html ?

Limit the error stream at https://github.com/mavlink/mavros/blob/master/mavros_extras/src/plugins/distance_sensor.cpp#L208
In case we send distance to FCU, at least on ardupilot, the message will be resend by the FCU so mavros spam the console.

Ok makes sense. @JD-ETH this may interest you, as Ardupilot already does what you are looking for.

support mavlink/mavlink#740 (if merged)

Yeah that should be straightforward.

Waiting your PR then :)

@khancyr
Copy link
Contributor Author

khancyr commented Jun 21, 2017

Yes I was thinking about laserscan, but it doesn't seem that ROS use a lot of 1D laser rangefinder. I will dig a little to see how they handle it.
Otherwise it could be use for Ardupilot proximity feature that act like a simplified 360 laserscan

@TSC21
Copy link
Member

TSC21 commented Jun 21, 2017

@khancyr check this: #292 (comment). For 1D Laser, we use INFRARED type in sensor_msgs/Range.

Otherwise it could be use for Ardupilot proximity feature that act like a simplified 360 laserscan

How do you have that implemented? Multiple DISTANCE_SENSOR msgs, one for each beam?

@TSC21
Copy link
Member

TSC21 commented Jun 21, 2017

Related: ros/common_msgs#73

@khancyr
Copy link
Contributor Author

khancyr commented Jun 21, 2017

interesting ! Thanks for the information !

About proximity, yes , each sector send a distance_sensor msg with a different id : http://ardupilot.org/dev/docs/code-overview-object-avoidance.html

@TSC21
Copy link
Member

TSC21 commented Jun 21, 2017

About proximity, yes , each sector send a distance_sensor msg with a different id : http://ardupilot.org/dev/docs/code-overview-object-avoidance.html

Thanks for sharing

@TSC21
Copy link
Member

TSC21 commented Jun 22, 2017

@khancyr are you considering doing a PR to this in the mean time?

@khancyr
Copy link
Contributor Author

khancyr commented Jun 22, 2017

yes probably next week, I am waiting some material to do test

@TSC21
Copy link
Member

TSC21 commented Jun 22, 2017

yes probably next week, I am waiting some material to do test

Awesome

@TSC21
Copy link
Member

TSC21 commented Jul 26, 2017

Solved with #747, #748, #749.

@TSC21 TSC21 closed this as completed Jul 26, 2017
@vooon vooon added this to the Version 0.20 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants