Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distance sensors: uncrustify and and new sensor type #747

Merged
merged 3 commits into from
Jul 26, 2017
Merged

Distance sensors: uncrustify and and new sensor type #747

merged 3 commits into from
Jul 26, 2017

Conversation

khancyr
Copy link
Contributor

@khancyr khancyr commented Jul 2, 2017 •
edited
Loading

need new mavlink released for : mavlink/mavlink@35a89a2

vooon
vooon approved these changes Jul 2, 2017
View reviewed changes
Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes done by uncrustify a bit strange, but rest looks good.
Next mavlink release planned on friday (2017.7.7).

mavros_extras/src/plugins/distance_sensor.cpp
switch (dist_sen.type) {
case enum_value(MAV_DISTANCE_SENSOR::LASER):
case enum_value(MAV_DISTANCE_SENSOR::RADAR):
case enum_value(MAV_DISTANCE_SENSOR::UNKNOWN):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unknown assumed as IR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the most common type on copter are 1-D Lidar that are laser type and IR on ROS. So that is why I chose this. Another posibillity could be to add another parameter on the config file. What do you think?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another posibillity could be to add another parameter on the config file.

What parameter would that be?

@TSC21 TSC21 closed this Jul 26, 2017
@TSC21 TSC21 reopened this Jul 26, 2017
@vooon
Copy link
Member

vooon commented Jul 26, 2017

Seems that Travis was broken:

executing command [sudo -H pip install -U -q future]

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:318: SNIMissingWarning: An HTTPS request has been made, but the SNI (Subject Name Indication) extension to TLS is not available on this platform. This may cause the server to present an incorrect TLS certificate, which can cause validation failures. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#snimissingwarning.

  SNIMissingWarning

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.

  InsecurePlatformWarning

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.

  InsecurePlatformWarning

ERROR: the following rosdeps failed to install

  pip: Failed to detect successful installation of [future]

@TSC21
Copy link
Member

TSC21 commented Jul 26, 2017

Yeah. But this can get in now, as Mavlink is already on deb packages.

@TSC21 TSC21 closed this Jul 26, 2017
@TSC21 TSC21 reopened this Jul 26, 2017
@TSC21 TSC21 closed this Jul 26, 2017
@TSC21 TSC21 reopened this Jul 26, 2017
@TSC21 TSC21 merged commit 0f49e21 into mavlink:master Jul 26, 2017
@TSC21 TSC21 mentioned this pull request Jul 26, 2017
Closed
@vooon vooon added this to the Version 0.20 milestone Jul 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TSC21 TSC21 TSC21 left review comments

@vooon vooon vooon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khancyr @vooon @TSC21