Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sensor_msgs: range: added LASER radiation type #73

Closed
wants to merge 1 commit into from

Conversation

TSC21
Copy link

@TSC21 TSC21 commented May 17, 2015

Related to mavlink/mavros#292 (comment).
[Jade release]

@tfoote
Copy link
Member

tfoote commented May 18, 2015

LASER is not a radiation type. So it's not appropriate to add to this enumeration.

The reason for this field is to know what types of objects will reflect vs not reflect. Ultrasonic vs infrared have very different behaviour when looking at glass for example.

As mentioned, in that comment, lasers can have different types of radiation. We could consider adding VISIBLE and ULTRAVIOLET to complement the existing INFRARED definition.

However I am not aware of a "light" based distance measuring device operating in the visible or ultraviolet frequencies.

There are also definitely microwave based sensors which might be applicable. However we try not to speculatively update messages until there is a clearly known use case.

From what sensor or sensors are you trying to represent the data using this message format?

@TSC21
Copy link
Author

TSC21 commented May 18, 2015

LASER is not a radiation type. So it's not appropriate to add to this enumeration.

Laser - "A laser is a device that emits light through a process of optical amplification based on the stimulated emission of electromagnetic radiation." I accept that radiation definition, but then it should also add NEAR_INFRARED. In this case we also have two kinds of radiation: electromagnetic and mechanical.

As mentioned, in that comment, lasers can have different types of radiation. We could consider adding VISIBLE and ULTRAVIOLET to complement the existing INFRARED definition.

The comment was referring to Lidar, which is a specific application for lasers.

However I am not aware of a "light" based distance measuring device operating in the visible or ultraviolet frequencies.

The reference to the other types of wavelength/radiotion used by Lidars comes from http://en.wikipedia.org/wiki/Lidar. Type depends on the application/range.

From what sensor or sensors are you trying to represent the data using this message format?

@tfoote
Copy link
Member

tfoote commented May 18, 2015

For both of those just use INFRARED we're not trying to represent the exact wavelength or specific taxonomy. We can use the general definition of INFRARED to cover things between visible and microwave.

https://en.wikipedia.org/wiki/Infrared
http://www2.lbl.gov/MicroWorlds/ALSTool/EMSpec/EMSpec2.html

@TSC21
Copy link
Author

TSC21 commented May 18, 2015

Will accept then @tfoote. Thanks for your time! Offtopic: is there a possibility of inserting covariance in the message definition?

@TSC21 TSC21 closed this May 18, 2015
@TSC21 TSC21 deleted the jade_range_type_laser branch May 18, 2015 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants