Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display progress for individual mission items #10828

Conversation

nexton-winjeel
Copy link
Contributor

@nexton-winjeel nexton-winjeel commented Oct 13, 2023

A proposed change in MAVLink adds mission item progress to the MISSION_CURRENT message: mavlink/mavlink#2029

This PR adds support for displaying this information on the FlyView map:
qgc-item-progress-distance
qgc-item-progress-count
qgc-item-progress-time

Associated ArduPilot PR: ArduPilot/ardupilot#25249

NOTE: This PR won't build as-is, because it doesn't include the changes to the MISSION_CURRENT message definition.

@Davidsastresas
Copy link
Member

This is really cool, thanks.

I think we should wait until the correspondent commits in mavlink and Ardupilot are approved, so we can update mavlink right away and make it work.

I haven't taken a deep look, but I noticed a typo in src/MissionManager/SimpleMissionItem.cc, "altitide" instead of "altitude".

Would you mind pinging me again when the PRs get merged in mavlink and autopilot to look into this again? Thanks!

@nexton-winjeel
Copy link
Contributor Author

This is really cool, thanks.

I think we should wait until the correspondent commits in mavlink and Ardupilot are approved, so we can update mavlink right away and make it work.

Agreed. The consensus on the ArduPilot side is that this capability applies to more than just mission items, so will require a new message rather than an extension to MISSION_CURRENT.

I haven't taken a deep look, but I noticed a typo in src/MissionManager/SimpleMissionItem.cc, "altitide" instead of "altitude".

Yep, thanks for that. I've fixed it, I just haven't pushed it because I know the builds will fail.

Would you mind pinging me again when the PRs get merged in mavlink and autopilot to look into this again? Thanks!

Will do. Thanks!

@ryanjAA
Copy link

ryanjAA commented Nov 26, 2023

Thanks! This is a great addition.

@DonLakeFlyer
Copy link
Contributor

You can reopen this once it's dependent parts (mavlink, ...) get completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants