-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] PID tuning v2 #5070
[WIP] PID tuning v2 #5070
Conversation
- Introduced fact stepper control that is mobile friendly - Added new screen for PID tuning for the PX4 copters Other changes: - Implement button repeat if its long pressed (must have for mobile stepper)
Use fact.shortDescription for all the params
… in the view ot have filter buttons on top
Auto install mock
…’t really do the flow Fix label alignment offset recalculation
I'll resolve the merge conflicts, then can we discuss this @DonLakeFlyer? |
Yeah, I'm out of town today-sunday. Won't be till next week. |
Not urgent, but I think having semi-accessible tuning screens is quite important. |
The other really big mess is log replay which is pretty broken right now. That also hurts tuning I think. |
Log replay is far more approachable for review in general to regular users. Even technical users initially struggle reviewing autopilot logs because they don't even know where to begin with the different fields. |
@dagar can you post a picture of what this looks like? |
I broke it during the rebase, let me try again. |
Hi @dagar and @DonLakeFlyer, it's been a while since I was here last time =) |
I hope to get to pid tuning in 3.4 |
Replaced by the new pid tuning stuff wip. |
@anton-matosov's PID tuning
Original #4458