Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] PID tuning v2 #5070

Closed
wants to merge 28 commits into from
Closed

[WIP] PID tuning v2 #5070

wants to merge 28 commits into from

Conversation

dagar
Copy link
Member

@dagar dagar commented Apr 27, 2017

@anton-matosov's PID tuning

Original #4458

- Introduced fact stepper control that is mobile friendly
- Added new screen for PID tuning for the PX4 copters

Other changes:
 - Implement button repeat if its long pressed (must have for mobile stepper)
Use fact.shortDescription for all the params
Auto install mock
…’t really do the flow

Fix label alignment offset recalculation
@dagar
Copy link
Member Author

dagar commented Apr 27, 2017

I'll resolve the merge conflicts, then can we discuss this @DonLakeFlyer?

@DonLakeFlyer
Copy link
Contributor

Yeah, I'm out of town today-sunday. Won't be till next week.

@dagar
Copy link
Member Author

dagar commented Apr 27, 2017

Not urgent, but I think having semi-accessible tuning screens is quite important.

@DonLakeFlyer
Copy link
Contributor

The other really big mess is log replay which is pretty broken right now. That also hurts tuning I think.

@dagar
Copy link
Member Author

dagar commented Apr 27, 2017

Log replay is far more approachable for review in general to regular users. Even technical users initially struggle reviewing autopilot logs because they don't even know where to begin with the different fields.

@dagar dagar self-assigned this Apr 27, 2017
@dagar dagar requested a review from DonLakeFlyer April 27, 2017 17:13
@dagar
Copy link
Member Author

dagar commented Apr 28, 2017

#2878

@jaxxzer
Copy link
Collaborator

jaxxzer commented May 2, 2017

@dagar can you post a picture of what this looks like?

@dagar
Copy link
Member Author

dagar commented May 10, 2017

I broke it during the rebase, let me try again.

@anton-matosov
Copy link
Contributor

Hi @dagar and @DonLakeFlyer, it's been a while since I was here last time =)
Are there any updates on these changes?

@DonLakeFlyer
Copy link
Contributor

I hope to get to pid tuning in 3.4

@DonLakeFlyer
Copy link
Contributor

Replaced by the new pid tuning stuff wip.

@DonLakeFlyer DonLakeFlyer deleted the PID-Tuning-v2 branch July 30, 2018 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants