Sub motor test fixes #9243
Merged
Sub motor test fixes #9243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Vehicle/Vehicle.cc
Outdated
| sendMavCommand(_defaultComponentId, MAV_CMD_DO_MOTOR_TEST, true, motor, MOTOR_TEST_THROTTLE_PERCENT, percent, timeoutSecs, 0, MOTOR_TEST_ORDER_BOARD); | ||
| // Sub requires periodic motortest messages, and we send them at a high rate to improve responsiveness. | ||
| // On higher latency connection, `showError=true` caused lots of "Unable to send command: Waiting on previous response to same command." errors. | ||
| bool showError = !sub(); |
There was a problem hiding this comment.
This isn't correct. This is an ArduSub problem not a "sub" problem isn't it?
There was a problem hiding this comment.
Right. What do you think of just exposing showError on the signature void Vehicle::motorTest(int motor, int percent, int timeoutSecs, bool showError) and letting qml decide it?
There was a problem hiding this comment.
ok, updated!
…with showErrors=false
Williangalvani
force-pushed
the
submotortest
branch
from
bb7848d
to
16aac36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stops the timer when it shouldn't be sending motor tests messages. This fixes some "motor test command failed" after user clicked the motor test toggle to stop the test/disarm, but the vehicle state in qgc hasn't received a disarmed heartbet yet
Disables showError for sub, fixing APM Sub: enabling motor test induces hundreds of mavlink command error popups #9234