Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete on text fields inside collections #8

Closed
LeaVerou opened this issue Feb 4, 2016 · 10 comments
Closed

Autocomplete on text fields inside collections #8

LeaVerou opened this issue Feb 4, 2016 · 10 comments
Labels
Effort: low Easy to address issues, ideal for first time contributors! enhancement

Comments

@LeaVerou
Copy link
Member

LeaVerou commented Feb 4, 2016

Autocomplete with values of the same property from other items of the collection.

@karger
Copy link
Collaborator

karger commented Feb 4, 2016

what if I want some other options in the autocomplete that aren't part
of any other item (yet)?

On 02/04/2016 05:30 PM, Lea Verou wrote:

Autocomplete with values of the same property from other items of the
collection.


Reply to this email directly or view it on GitHub
https://github.com/LeaVerou/wysie/issues/8.

@LeaVerou
Copy link
Member Author

LeaVerou commented Feb 4, 2016

Any actual use cases in mind?

You would have to type them at least once to add them to the autocomplete, so you may as well type them once to add them as values to the property (which would also add them to the autocomplete). If you don't plan to use them as values to the property, why have them in the autocomplete? As partial values, perhaps? Or maybe that would be useful in cases where the person creating the template is different than the person editing the data (which I expect to be many).

@LeaVerou LeaVerou added the Effort: low Easy to address issues, ideal for first time contributors! label Oct 26, 2016
@Dsan10s
Copy link
Contributor

Dsan10s commented Apr 14, 2017

We discussed having the browser achieve this functionality natively, do we still want to go down that path, or code autocomplete manually to have more control?

@karger
Copy link
Collaborator

karger commented Apr 14, 2017 via email

@Dsan10s
Copy link
Contributor

Dsan10s commented Apr 14, 2017

Sorry, what I mean by "code manually" is to make the implementation of autocomplete ourselves, vs using the browser's native autocomplete functionality

@LeaVerou
Copy link
Member Author

LeaVerou commented Apr 14, 2017 via email

@karger
Copy link
Collaborator

karger commented Apr 14, 2017 via email

@LeaVerou
Copy link
Member Author

LeaVerou commented Apr 14, 2017

David, the idea was that people will automatically get autocomplete for the other values of the same property. They wouldn't have to know or care how that autocomplete was implemented.
And yes, it may be a good idea to have it as a plugin, especially if we don't use the browser's native functionality.

Btw, if people want to use the browser functionality, I realized later they can do it themselves, via existing Mavo functionality:

<div property="foo" mv-edit-list="foo"></div>

and then somewhere in the page:

<datalist id="foo">
    <option property="fooAutocomplete" mv-multiple mv-value="unique(foo)">
</datalist>

I should probably add a demo or docs about this.

@LeaVerou
Copy link
Member Author

So, since this is already possible with expressions, I'm inclined to close this, unless you guys disagree.

@karger
Copy link
Collaborator

karger commented Apr 14, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: low Easy to address issues, ideal for first time contributors! enhancement
Projects
None yet
Development

No branches or pull requests

3 participants