Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ReferenceError: closestItem is not defined #1025

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

C-Ezra-M
Copy link

@C-Ezra-M C-Ezra-M commented Jul 1, 2024

Occurred to me while trying to use list-separator. This is a temporary solution until this section of code can be properly DRYfied.

DmitrySharabin and others added 3 commits June 28, 2024 21:15
Occurred to me while trying to use list-separator. This is a temporary solution until this section of code can be properly DRYfied.
Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for getmavo ready!

Name Link
🔨 Latest commit 8276e86
🔍 Latest deploy log https://app.netlify.com/sites/getmavo/deploys/6682d0df8617ce00075cc0ed
😎 Deploy Preview https://deploy-preview-1025--getmavo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

C-Ezra-M added a commit to C-Ezra-M/coben-calc that referenced this pull request Jul 7, 2024
As long as mavoweb/mavo#1025 is active, Netlify will deploy the new codebase as a script that can be included with a <script> tag. I will make it use the upstream version once that PR is merged.
Copy link
Member

@DmitrySharabin DmitrySharabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, wow. How on earth we didn't notice this earlier? Thank you so much for finding and fixing this.

A bit of context: this code handles the case when one tries to paste multiple items in a list item. I'm not sure how long this feature has been broken. 🤷‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants