Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce function #21

Merged
merged 7 commits into from
Mar 18, 2024
Merged

reduce function #21

merged 7 commits into from
Mar 18, 2024

Conversation

adamjanicki2
Copy link
Contributor

Addresses a part of #11

Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for treecle ready!

Name Link
🔨 Latest commit 24e1feb
🔍 Latest deploy log https://app.netlify.com/sites/treecle/deploys/65f8321103ed260008f8903d
😎 Deploy Preview https://deploy-preview-21--treecle.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

src/reduce.js Outdated Show resolved Hide resolved
src/reduce.js Outdated

/**
* Reduce a tree to a single value
* @param {object} node
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will JSDoc complain if we use {Node} in these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to respond to this, but I can check; npm run build:docs is currently not working for some reason so I'm trying to debug it before I can check whether or not this would work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2024-03-16 at 8 07 37 AM

Looks like it works!

Copy link
Member

@LeaVerou LeaVerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will re-iterate that we should discuss design first before implementing, but this seems straightforward enough.

@adamjanicki2 adamjanicki2 mentioned this pull request Mar 16, 2024
@adamjanicki2 adamjanicki2 merged commit 762d8fa into main Mar 18, 2024
4 checks passed
@adamjanicki2 adamjanicki2 deleted the reduce branch March 18, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants