-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reduce
function
#21
reduce
function
#21
Conversation
✅ Deploy Preview for treecle ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/reduce.js
Outdated
|
||
/** | ||
* Reduce a tree to a single value | ||
* @param {object} node |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will JSDoc complain if we use {Node}
in these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to respond to this, but I can check; npm run build:docs
is currently not working for some reason so I'm trying to debug it before I can check whether or not this would work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will re-iterate that we should discuss design first before implementing, but this seems straightforward enough.
Addresses a part of #11