Add arrayTypeSize option, alternative to passing constructor in arrayType #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deathcap do you have voxel-engine merge access? You're really carrying the project right now, so if not we would happily add you. |
|
This commit is included in #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'arrayType' option allows the type of the array for voxels to be configured, but it requires passing a constructor - problematic in some situations since it cannot be directly JSON serialized. For example, voxel-client/voxel-server sends the voxel-engine settings over the network as JSON, or other modules may want to otherwise persist these settings, but
arrayType: Uint16Arraydoesn't make it through.So this PR adds an alternative option, arrayTypeSize - an easily-serializable integer, representing the number of bytes for the typed array (1, 2, or 4 for Uint8Array, Uint16Array, or Uint32Array, respectively).