cork/uncork logic client fix #147
Conversation
stream.js
Outdated
| if (isBrowser) { | ||
| stream = proxy | ||
| stream.cork() | ||
| socket.onopen = onopenBrowser |
There was a problem hiding this comment.
can the same logic be applied to Node as well? What will cause issues?
There was a problem hiding this comment.
I'll try to use same logic for Node and browser, but for Node needed duplexify logic for destroy() method as I see.
|
@mcollina, if structure fixed. So, what do you think? |
|
I don't really understand why we can't use the same logic for Node as well. |
|
@mcollina, You can try to clone and remove last else block from upper code block and to run server tests. As I see lib use some destroy logic included in duplexify for server side using lib. Maybe I understood something wrong. |
|
@mcollina, Hello. Do you tried to rewrite w/o duplexify? |
|
Unfortunately I have no time atm :/
Il giorno mar 29 gen 2019 alle 17:20 scarry1992 <notifications@github.com>
ha scritto:
… @mcollina <https://github.com/mcollina>, Hello. Do you tried to rewrite
w/o duplexify?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#147 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADL437wgZa3iaBbqLnQjmc6XlTNgPj3ks5vIHTAgaJpZM4aWE8f>
.
|
|
@mcollina, so what about that PR? |
|
@mcollina, do you release it in npm? |
|
Yes, v5.2.0. |
No description provided.