Dialog directives: Intent should be nullable in create() method #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
November 30, 2017 16:37
…g to the Amazon documentation. It should therefore be nullable in the create() method.
…emoved unused $value property from Slot
maxbeckers
reviewed
Nov 30, 2017
src/Intent/Intent.php
Outdated
|
|
||
| $data['name'] = $this->name; | ||
| if (null !== $this->confirmationStatus) | ||
| { |
There was a problem hiding this comment.
Codestyle is to add the opening brace to the end of line for if or for and not in a new line. if (...) { can you please fix this for all files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated Intent is not required for all Dialog directives according to the Amazon documentation. It should therefore be nullable in the create() method.
See Amazon documentation:
https://developer.amazon.com/de/docs/custom-skills/dialog-interface-reference.html#directives
I additionally fixed the JSON serialization of the Intent object (Needed for DialogDirectives with "updatedIntent"). The output JSON now matches the input JSON.