Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The updates to the logger #14

Closed
wants to merge 3 commits into from
Closed

Conversation

tarmack
Copy link
Contributor

@tarmack tarmack commented Oct 6, 2011

Hey Max,

Here is the logger update.

I did some updates on the threadpool tests, they come with this automatically, enjoy.

@maxcountryman
Copy link
Owner

Hey this is a good start. It'd be nice to have some unit tests for the logger first though and I'm not sure if your commit message is current, but it says not finished.

@tarmack
Copy link
Contributor Author

tarmack commented Oct 6, 2011

That is only the first commit, the second one contains the "final" code.

There is a small unit test in there also, it's not complete yet.

On Thursday 06 October 2011 21:29:06 you wrote:

Hey this is a good start. It'd be nice to have some unit tests for the
logger first though and I'm not sure if your commit message is current,
but it says not finished.

@maxcountryman
Copy link
Owner

Okay what about a unit test for the logger?

@tarmack
Copy link
Contributor Author

tarmack commented Oct 9, 2011

There is a simple one, making it better is still on the todo list. This will be quite complicated I'm affraid. You need to check the contents of the files created and fill them to the point that rollover should occur. This will be quite fragile I think.

I'm currently knee deep in another project so won't be working on irctk much.

@maxcountryman
Copy link
Owner

Okay closing this for now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants