Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate UI context #27

Merged
merged 2 commits into from
Apr 15, 2018
Merged

Add separate UI context #27

merged 2 commits into from
Apr 15, 2018

Conversation

mks-m
Copy link
Collaborator

@mks-m mks-m commented Apr 14, 2018

also do glClear only once per frame in app

@mks-m mks-m requested a review from maxfish April 14, 2018 20:35
Copy link
Owner

@maxfish maxfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the issue we have talked about, this is good to go

pkg/app/app.go Outdated
a.FpsCounterText.SetText(fmt.Sprintf("%v", a.FpsCounter.FPS()))
a.Context.EnqueueForDrawing(a.FpsCounterText)
a.UIContext.EnqueueForDrawing(a.FpsCounterText)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move the uicontext drawing after the main context is rendered? I know it doesn't change much but it give better the idea that the UI is on top of everything else

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that was me moving the code around trying to debug the glitch

@mks-m mks-m merged commit 348e2f7 into master Apr 15, 2018
@maxfish maxfish deleted the ui-context branch August 14, 2018 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants