Merge SetUniformXYZ methods into one with switch by type #5
Conversation
| @@ -118,24 +118,28 @@ func (s *ShaderProgram) GetUniform(name string) int32 { | |||
| return uniform | |||
| } | |||
|
|
|||
| func (s *ShaderProgram) SetUniform4f(name string, value [4]float32) { | |||
| func (s *ShaderProgram) SetUniform(name string, val interface{}) { | |||
There was a problem hiding this comment.
I'm a bit concerned about the performances of this method. It will be called several times per primitive per frame.
Uniform1fv for one single float might be slower than Uniform1f (we should benchmark it), for the other I think the compiler might be able to select the right switch without runtime penalty
There was a problem hiding this comment.
yeah, i think this is really micro-optimizing it. this should be good enough for vast majority of cases. but i will run some benchmarks but type switch is on level of nanoseconds: https://stackoverflow.com/questions/28024884/does-a-type-assertion-type-switch-have-bad-performance-is-slow-in-go
There was a problem hiding this comment.
My concern was only about the single float32 case: uniform1fv vs uniform1f
I don't think there will be much difference and, anyway, we can always swap them.
Good to go!
No description provided.