Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use images from the public folder instead of looking up within frontend #53

Closed
maxime1992 opened this issue Dec 14, 2017 · 0 comments
Closed
Assignees

Comments

@maxime1992
Copy link
Owner

Thanks to PR #51 (with docker), I noticed a weird thing in code:

I decided to use the local images directly from the frontend folder instead of using the ones from backend/public.

This is because while we develop, we don't have to build the frontend and put it in backend/public.

But with Docker, we only keep the backend folder and thus, we loose all local pictures.

@maxime1992 maxime1992 self-assigned this Dec 14, 2017
maxime1992 added a commit that referenced this issue Dec 28, 2017
Split Dockerfile in 2: API and NGINX

Closes #53 #54
maxime1992 added a commit that referenced this issue Dec 28, 2017
Split Dockerfile in 2: API and NGINX

Closes #53 #54
maxime1992 added a commit that referenced this issue Aug 18, 2018
Split Dockerfile in 2: API and NGINX

Closes #53 #54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant