Refactor categories so classes can be used by external code #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@amccardie's recent enhancement to support Vera UI5 highlighted that device.category was being used by HA, and so the code had to override the categories from Vera to get HA to treat them the same way.
Given we already have classes for most device types I think it's better for library user to depend on classes rather than categories.
This also highlighted that some sensor types weren't being mapped as sensors, and that what was called a sensor class was really a binary sensor.
I also removes the turn on / turn off code from the sensor - since it doesn't really make sense.
Coded - but not yet tested.
Will require a paired HA vera change - also coded but not yet tested.