Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Sheet disableSwitchColorView icon remains #23

Closed
russellbanks opened this issue Jan 1, 2021 · 1 comment
Closed

Color Sheet disableSwitchColorView icon remains #23

russellbanks opened this issue Jan 1, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@russellbanks
Copy link
Contributor

Describe the bug
On the color sheet, disableSwitchColorView() disables the ability to switch to the custom color view. However, the icon still remains - it just doesn't do anything.

Library Version:
1.1.0

To Reproduce
Steps to reproduce the behavior:

  1. Add disableSwitchColorView() to the code
  2. The icon to switch the color view remains

Expected behavior
The icon should go away if disableSwitchColorView() is enabled.

Screenshots
I've attached a video showing this bug in the sample app

20-01-01-18-15-00.mp4
@russellbanks russellbanks added the bug Something isn't working label Jan 1, 2021
maxkeppeler added a commit that referenced this issue Jan 1, 2021
@maxkeppeler
Hide type icon button if switching view is disabled #23
1ebc71e
@maxkeppeler
Copy link
Owner

Thank you a lot. I'm sorry for the 2 issues you have reported - I've rushed a bit with the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxkeppeler @russellbanks