Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added width parameter to builder and show #43

Merged
merged 2 commits into from
Jan 27, 2021

Conversation

firetrap
Copy link

I've made some changes to be able to change the width of the view, it doesn't break any of your changes.
I keep intact the default width value as MATCH_PARENT but now it's customizable

@maxkeppeler maxkeppeler merged commit 6ea1593 into maxkeppeler:main Jan 27, 2021
@maxkeppeler
Copy link
Owner

maxkeppeler commented Jan 27, 2021

I just noticed some issues and there removed the commits, sorry. Issues I noticed are:

Dialog & Bottom Sheet

  • When viewWidth is larger than width is available, the view is cut on the right edge. Should be possible to prevent that and just use MATCH_PARENT / the available width instead of a higher width.

Bottom Sheet

  • It starts to "jump" up, the normal smooth animation is gone
  • It creates a gap below the bottom-sheet, which is grey or empty.
  • The shadow around the bottom-sheet is cut off, I guess it's not supposed to like this as it looks a bit weird, but I have to check this.

@firetrap
Copy link
Author

I just noticed some issues and there removed the commits, sorry. Issues I noticed are:

Dialog & Bottom Sheet

  • When viewWidth is larger than width is available, the view is cut on the right edge. Should be possible to prevent that and just use MATCH_PARENT / the available width instead of a higher width.

Bottom Sheet

  • It starts to "jump" up, the normal smooth animation is gone
  • It creates a gap below the bottom-sheet, which is grey or empty.
  • The shadow around the bottom-sheet is cut off, I guess it's not supposed to like this as it looks a bit weird, but I have to check this.

Sorry I didn't notice the gap and was a bit late. I confirm the issue, if I've time I will take a look. I think the gap and the shadow will give some work but the others are easy fixable

@maxkeppeler
Copy link
Owner

No problem, my mistake as well. On first sight it seemed like everything was working.

@maxkeppeler
Copy link
Owner

Alright! That would be cool. Definitely open for this change when it works well and doesn't break anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants