fix(claim): improve SnakValue type #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also some minor Claim/Snak typing improvements
I can't figure out why I put it there in the first place, otherwise than by confusion, so let's remove it and find out ^^
|
Regarding the |
EdJoPaTo
commented
Jun 13, 2023
Comment on lines
+18
to
+21
| /** @deprecated use WikibaseItemSnakValue */ | ||
| export type SnakEntityValue = WikibaseEntityIdSnakValue | ||
| /** @deprecated use WikibaseItemSnakValue */ | ||
| export type ClaimSnakWikibaseItem = WikibaseEntityIdSnakValue |
There was a problem hiding this comment.
oups… looks like the deprecated hint points to the wrong object name. Its easy to find out when looking into the code so not that important to fix?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also some minor Claim/Snak typing improvements.
SnakValue typings should be complete based on what I found here.
Something I am not sure about: no
Snak(QualifierandReferenceSnakincluded) contains an id (from the real world data I observed.its optional for Snak but required for ReferenceSnak and Qualifier. I think this is wrong and can be remove on all 3 of them. But I might be missing something so can someone confirm me here? Its there so it probably has a reason?