Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Remove logl kwarg (always use log-likelihoods) #22

Merged
merged 18 commits into from
Jun 11, 2020
Merged

Conversation

maxmouchet
Copy link
Owner

@maxmouchet maxmouchet commented Jun 7, 2020

  • Remove logl keyword argument
  • Remove forward!, backward!, viterbi!
  • Update documentation
  • Update benchmarks

@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13         9    -4     
  Lines          380       319   -61     
=========================================
- Hits           380       319   -61     
Impacted Files Coverage Δ
src/utilities.jl 100.00% <ø> (ø)
src/HMMBase.jl 100.00% <100.00%> (ø)
src/likelihoods.jl 100.00% <100.00%> (ø)
src/messages.jl 100.00% <100.00%> (ø)
src/mle.jl 100.00% <100.00%> (ø)
src/viterbi.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14e0bd2...5af89e9. Read the comment docs.

@maxmouchet maxmouchet mentioned this pull request Jun 11, 2020
@maxmouchet maxmouchet force-pushed the remove_logl branch 2 times, most recently from bbaddd8 to 5af89e9 Compare June 11, 2020 15:55
@maxmouchet maxmouchet changed the title Use log-likelihoods everywhere Remove logl kwarg (always use log-likelihoods) Jun 11, 2020
@maxmouchet maxmouchet merged commit 88068bc into master Jun 11, 2020
@maxmouchet maxmouchet deleted the remove_logl branch June 11, 2020 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant