Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lipsync Converter: Index out of range exception #20

Closed
maxton opened this issue Dec 28, 2018 · 2 comments
Closed

Lipsync Converter: Index out of range exception #20

maxton opened this issue Dec 28, 2018 · 2 comments
Labels
bug Something isn't working song-specific Issues found when converting certain songs

Comments

@maxton
Copy link
Owner

maxton commented Dec 28, 2018

The cause of errors on many customs.

e.g. "Back in Black - ACDC", "Hells Bells - ACDC", "Black Smoke Rising - Greta Van Fleet" to name a few
@maxton maxton added bug Something isn't working song-specific Issues found when converting certain songs labels Dec 28, 2018
@PikminGuts92
Copy link
Contributor

I forgot to take into account that the various lipsync files can have different frame counts within the same song.

@PikminGuts92 PikminGuts92 mentioned this issue Dec 29, 2018
Merged
@maxton
Copy link
Owner Author

maxton commented Dec 29, 2018

Fixed by #25. Thanks @PikminGuts92

@maxton maxton closed this as completed Dec 29, 2018
@maxton maxton mentioned this issue Dec 29, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working song-specific Issues found when converting certain songs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxton @PikminGuts92