Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARView Weak #19

Merged
merged 2 commits into from
Apr 1, 2021
Merged

ARView Weak #19

merged 2 commits into from
Apr 1, 2021

Conversation

maxxfrazer
Copy link
Owner

@maxxfrazer maxxfrazer commented Apr 1, 2021 •
edited
Loading

  • Set ARView reference to weak
  • Fix setAutoUpdate method to cancel update if arview is nil

Thanks @arthurschiller for suggesting this!

@maxxfrazer maxxfrazer self-assigned this Apr 1, 2021
arthurschiller
arthurschiller approved these changes Apr 1, 2021
View reviewed changes
Copy link

@arthurschiller arthurschiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that looks good! Maybe these if-statements could be replaced with guards to make it more Swifty, but I guess that's more of a stylistic change.

@maxxfrazer maxxfrazer merged commit a8de187 into main Apr 1, 2021
@maxxfrazer maxxfrazer deleted the weak branch April 1, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthurschiller arthurschiller arthurschiller approved these changes

Assignees

@maxxfrazer maxxfrazer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxxfrazer @arthurschiller