Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI improvements #33

Merged
merged 26 commits into from
Apr 24, 2023
Merged

CI improvements #33

merged 26 commits into from
Apr 24, 2023

Conversation

resolritter
Copy link
Collaborator

close #29

@resolritter resolritter marked this pull request as ready for review April 24, 2023 11:10
@resolritter
remove obsolete ready_for_review trigger
ff014bd
@resolritter
better handling of failures
6e98e4c
@resolritter
use npm ci for reproducible builds
b1ffd9e
@resolritter
less confusing message
fc086dd
@resolritter
update the parser
d80a8c0
@resolritter
pin the tree-sitter version
766a9ab 
contributors might generate parser files incompatible with the project's CI
after `npm install` if the version is not pinned
@resolritter
Revert "update the parser"
c256b66 
This reverts commit d80a8c0.
@resolritter
update the package lock
162d737
@resolritter
update the parser
cb91ae8
@resolritter
show git diff changes
fd920aa
@resolritter
Revert "update the parser"
1560eaa 
This reverts commit cb91ae8.
@resolritter
improve CI debugging
d05a682
@resolritter
undo artifacts uploading; truncate output for large diffs
030f657
@resolritter
show newline after truncation
0a61e40
@resolritter
regenerate the parser
88937a3
@resolritter
Revert "regenerate the parser"
da20ce4 
This reverts commit 88937a3.
@resolritter
Copy link
Collaborator Author

resolritter commented Apr 24, 2023 •
edited

1 - In 0a61e40 the check was failing because the parser files are outdated.

2 - In 88937a3 the parser's files were regenerated with npm run generate and committed, which made the check pass.

3 - I reverted 88937a3 in da20ce4, so the check is failing again.

Seems like it's working as intended. I'm going to merge this as-is and follow up with a new pull request for fixing the parser files.

@resolritter resolritter merged commit 4da0a74 into maxxnino:main Apr 24, 2023
1 check failed
@resolritter resolritter deleted the parser branch April 24, 2023 12:40
This was referenced Apr 24, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better handling of generated files
1 participant
@resolritter