Refactor test suite completion #20

borb · 2016-09-19T12:58:02Z

This constitutes release 0.1.0.

- global constants to class constants - global variables will be removed from the code

php 5 supports this natively

...don't. enjoy the fatal error, but seriously, load extenions in php.ini.

- public/private scopes - move legacy constructor/destructor to -compat - don't alias Util as PEAR, it's confusing - psr-2 tidiness

ref issue #16

buildManipSQL() can build an UPDATE without a WHERE. this could be super stupid if the user sets the WHERE flag to a programmed value, and could wreck a database table. this adds a method to help a developer consider the consequences of their actions.

first issue is that the empty select returner doesn't return a properly formatted result. second issue is missing the ability to fail when it comes to returning data, simulating a connection breakdown after a query has successfully executed.

ref issue #1

fetchInto() returns null in case of error or no data, and in any case, would return the error object as the return value as opposed to the assign-by-ref value passed into the method. basically, this is unreachable.

ref issue #1

closes #1

borb added 30 commits June 15, 2016 16:43

move global constants to class, "fixed" in compat

39e46fb

globals to class properties

1021806

- global constants to class constants - global variables will be removed from the code

this can become a proper private variable

495b43b

get rid of the bivalent method mechanism

6f10c39

php 5 supports this natively

global to class constants

056c5ab

remove expected errors and bivalent method array

3b36675

move PEAR/_PEAR to -compat, bivalent call method gone

f678cae

remove deprecated call-by-ref

f9e1062

bivalent calls are gone

5633ce6

just removing loadExtension. if you use it...

b77a135

...don't. enjoy the fatal error, but seriously, load extenions in php.ini.

refactoring error

e269662

- public/private scopes - move legacy constructor/destructor to -compat - don't alias Util as PEAR, it's confusing - psr-2 tidiness

constructors are (mostly) always public

f266c81

bring exception in from pear, and remove evil eval()

187f9b6

say goodbye to fake destructors and error stacks

3fa9999

since the error stacks are gone, these calls can go.

c5f88cc

redundant variables, psr-2 raiseError dec, class names

a2be970

skiptrace was never used by us, getStaticProperty can thus die

ae8fb81

i have never seen apiVerison used. that can go.

755d41d

drop refs to PEAR, use instanceof, psr-2

46a0854

backport fix from pdoMysql.php driver

8b532fc

result buffering feature (needs doctrine-isation)

3498011

use class constants

6c55dd8

we're not ignoring backtraces (but don't use them)

9445355

don't import PineappleUtil ns, don't alias it

07c7da8

resolve psr-2 issues

c38dae7

psr-2, replace htmlspecialchars with htmlentities

c970399

little bit of psr-2, tidy

adb6454

map props to array, not undeclared class props

813dc14

psr-2 refactor, fix consts to work without -compat

94970aa

remove conditional code since we're using dbal

8a19c29

borb and others added 28 commits September 15, 2016 10:18

set some scopes (issue #16)

fb7eb48

test tokenised query emulation

0458992

this code is not testable without vfsStream

62c9b47

stub method to test protected method in Common

df19367

psr-2 refactor of Common. 4 warnings, 0 errors

b876af7

ref issue #16

cope with protected properties in Common

34765e3

use this naming convention for classes in future

acebcf1

wow, missed this bad constant whilst writing mock

243f596

some more test coverage (ref issue #1)

65a2e6e

stubs for failure during prep, limitQuery

e6808a0

more test coverage of Common class (ref issue #1)

1c40fdf

fix up some issues in TestDriver

754493f

first issue is that the empty select returner doesn't return a properly formatted result. second issue is missing the ability to fail when it comes to returning data, simulating a connection breakdown after a query has successfully executed.

fix up marked incomplete test and add several more

22dc88c

ref issue #1

simulate single column fetches

e53132d

more test cases for getAssoc

ac76a20

this is unreachable code

8b2e7b2

fetchInto() returns null in case of error or no data, and in any case, would return the error object as the return value as opposed to the assign-by-ref value passed into the method. basically, this is unreachable.

remove duplicate arrays, cover getAll()

8e6a311

force boolean resolution at set time

3d82132

set scope for this method as in Common

c105cc0

remove uncalled mock methods so we can test Common

23b356b

another swathe of tests for Common

a0782f4

unreachable code

319a40f

more stubs for protected methods

6f0a1d3

almost done. one method left to cover.

88d46fb

ref issue #1

drop dbal test (noop), finish coverage

14593e8

closes #1

move this annotation to the end of the comment

756deb0

license value

5f50b16

borb merged commit f8c0a23 into master Sep 19, 2016

borb deleted the deeper-refactor branch September 19, 2016 13:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor test suite completion #20

Refactor test suite completion #20

borb commented Sep 19, 2016

Refactor test suite completion #20

Refactor test suite completion #20

Conversation

borb commented Sep 19, 2016