-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 #227 - fix: fix a bug that prevent the record manager from reas… #239
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
+ Coverage 76.89% 77.62% +0.72%
==========================================
Files 193 197 +4
Lines 5653 5864 +211
Branches 106 108 +2
==========================================
+ Hits 4347 4552 +205
- Misses 1203 1207 +4
- Partials 103 105 +2 ☔ View full report in Codecov by Sentry. |
d3b6de7
to
1949d14
Compare
The endpoint now no longer provides error messages when:
Can you pick this PR up and address the issues (and validate that the frontend shows them correctly)? |
1949d14
to
27c24b8
Compare
a08c4bf
to
840afe7
Compare
…ing a reviewer when the destruction list is in review
3221d07
to
c42083d
Compare
c42083d
to
99813df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging this as base functionlity now works. However in a certain scenario behavior may be improved:
- Flipping the reviewers (2 -> 1, 1 -> 2) does not work.
…signing a reviewer when the destruction list is in review
This requires: