Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 #227 - fix: fix a bug that prevent the record manager from reas… #239

Merged
merged 9 commits into from
Aug 8, 2024

Conversation

svenvandescheur
Copy link
Contributor

@svenvandescheur svenvandescheur commented Jul 30, 2024

…signing a reviewer when the destruction list is in review

This requires:

  • A backend implementation that adds an endpoint to reassign a user
  • A frontend change that implements the previously mentioned backend endpoint
  • Error handling
  • Update current assignee

@svenvandescheur svenvandescheur mentioned this pull request Jul 30, 2024
5 tasks
@codecov-commenter
Copy link

codecov-commenter commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 93.19372% with 26 lines in your changes missing coverage. Please review.

Project coverage is 77.62%. Comparing base (ca2f1a1) to head (99813df).

Files Patch % Lines
...tructionListAssignees/DestructionListAssignees.tsx 0.00% 13 Missing and 2 partials ⚠️
...ructionlist/detail/DestructionListDetail.action.ts 0.00% 4 Missing ⚠️
...c/openarchiefbeheer/destruction/api/serializers.py 94.59% 2 Missing ⚠️
.../openarchiefbeheer/destruction/assignment_logic.py 96.66% 2 Missing ⚠️
...ackend/src/openarchiefbeheer/destruction/models.py 92.85% 2 Missing ⚠️
frontend/src/lib/api/destructionLists.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
+ Coverage   76.89%   77.62%   +0.72%     
==========================================
  Files         193      197       +4     
  Lines        5653     5864     +211     
  Branches      106      108       +2     
==========================================
+ Hits         4347     4552     +205     
- Misses       1203     1207       +4     
- Partials      103      105       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur
Copy link
Contributor Author

@SilviaAmAm

The endpoint now no longer provides error messages when:

  • The same user is assigned multiple times
  • The author is assigned (as reviewer)

Can you pick this PR up and address the issues (and validate that the frontend shows them correctly)?

@SilviaAmAm SilviaAmAm marked this pull request as ready for review August 8, 2024 08:43
Copy link
Contributor Author

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this as base functionlity now works. However in a certain scenario behavior may be improved:

  • Flipping the reviewers (2 -> 1, 1 -> 2) does not work.

@svenvandescheur svenvandescheur merged commit f3660d9 into main Aug 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants