Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For klanten contacten and partij endpoints the expand query documentation lists a single Betrokkene #208

Closed
hsiliev opened this issue Jul 31, 2024 · 0 comments · Fixed by #222
Assignees
Labels
bug Something isn't working owner: dimpact triage

Comments

@hsiliev
Copy link

hsiliev commented Jul 31, 2024

Product versie / Product version

2.1

Omschrijf het probleem / Describe the bug

klanten contacten returns an array of Betrokkene. In the same time the expand query returns only a single Betrokkene in the had_betrokkenen field.

partijen has the same issue. Its expand returns a single Betrokkene according to OpenAPI docu.

Stappen om te reproduceren / Steps to reproduce

  1. Open https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/open-klant/2.1.0/src/openklant/components/klantinteracties/openapi.yaml#/klanten%20contacten/klantcontactenList
  2. The 200 example value has this:
    "_expand": {
            "had_betrokkenen": {
    

and

  1. Open https://petstore.swagger.io/?url=https://raw.githubusercontent.com/maykinmedia/open-klant/2.1.0/src/openklant/components/klantinteracties/openapi.yaml#/partijen/partijenList
  2. The 200 example has a single betrokkenen

Verwacht gedrag / Expected behavior

The API documentation should mention that expand returns an array of Betrokkene values, not a single Betrokkene

This also affects the generated models and clients

@hsiliev hsiliev added bug Something isn't working triage labels Jul 31, 2024
@hsiliev hsiliev changed the title For klanten contacten endpoint the expand query documentation lists a single Betrokkene For klanten contacten and partij endpoints the expand query documentation lists a single Betrokkene Aug 1, 2024
@bart-maykin bart-maykin self-assigned this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working owner: dimpact triage
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants