[#13] reuse open-api-workflows workflows #238
Conversation
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
9f6a3d0
to
86c494a
Compare
|
This PR requires an updated version of OAF, see the code qualities job and the PR made in OAF. |
SonnyBA
requested review from
stevenbal,
bart-maykin,
annashamray and
Coperh
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
2f41a28
to
915a644
Compare
There was a problem hiding this comment.
@SonnyBA could you solve the merge conflicts? Also one of the jobs is failing, not sure why https://github.com/maykinmedia/open-klant/actions/runs/11178494784/job/31076178777?pr=238
SonnyBA
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
12c5370
to
6a4a5f7
Compare
|
@stevenbal regarding the failing job, there still is this comment to consider before merging |
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
6a4a5f7
to
a20f0e3
Compare
but base it entirely off of base.txt
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
be3ae06
to
3c2c8be
Compare
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
3c2c8be
to
e80ba3d
Compare
this version moves the auth middleware to the proper directory, to avoid unnecessary migrations if the authorizations app is unused also remove the vng_api_common.authorizations.AuthMiddleware from the MIDDLEWARE setting, because Open Klant does not use JWT authentication
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
e80ba3d
to
c42cf93
Compare
|
@annashamray @Coperh @bart-maykin this PR is ready for review again |
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
stevenbal
force-pushed
the
feature/13-consistent-ci-configuration
branch
from
c1faaf1
to
95789cc
Compare
Fixes maykinmedia/open-api-framework#13
Changes
Reuses open-api-workflows workflows to make CI jobs consistent across the different projects.