Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ARM community builder support #164

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Adding ARM community builder support #164

merged 1 commit into from
Jan 31, 2019

Conversation

codexlynx
Copy link
Contributor

List of Changes Proposed

Added support for the Arm Packer builder.

Testing Evidence

$ pytest tests/packerlicious/community/test_builder_arm.py
================================================== test session starts ==================================================
platform linux -- Python 3.6.7, pytest-4.1.1, py-1.7.0, pluggy-0.8.1 -- /home/user/packerlicious/venv/bin/python
cachedir: .pytest_cache
rootdir: /home/user/packerlicious, inifile: setup.cfg
collected 1 item                                                                                                        

tests/packerlicious/community/test_builder_arm.py::TestArmBuilder::test_required_fields_missing PASSED            [100%]

=============================================== 1 passed in 0.01 seconds ================================================```

@codexlynx codexlynx changed the title Adding ARM community builder Adding ARM community builder support Jan 30, 2019
@coveralls
Copy link

coveralls commented Jan 30, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 7afc599 on codexlynx:feature/add-builder-arm-image-support into 44a4301 on mayn:master.

Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codexlynx , thanks for taking the time to add this!

  1. I noticed the arm-image builder supports some other parameters in its source, do we want to add those too?
  2. few minor name changes, see the suggestions.

src/packerlicious/community/builder.py Outdated Show resolved Hide resolved
tests/packerlicious/community/test_builder_arm.py Outdated Show resolved Hide resolved
@codexlynx
Copy link
Contributor Author

Hi @coveralls, the renaming is a good idea. Regarding the second point, yes it is true, but the parameters are undocumented. They only have the example templates. For me and my use case is okay. What do you think?

@mayn
Copy link
Owner

mayn commented Jan 31, 2019

@codexlynx thanks for the feedback. I opened an issue with project maintainers for help adding additional attributes.

@mayn mayn added this to the 1.2.0 milestone Jan 31, 2019
@mayn mayn merged commit 300b9c2 into mayn:master Jan 31, 2019
@codexlynx
Copy link
Contributor Author

Thanks you for this project.

@codexlynx codexlynx deleted the feature/add-builder-arm-image-support branch February 6, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants