Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for LXC builder #37

Merged
merged 1 commit into from
Oct 10, 2017
Merged

Support for LXC builder #37

merged 1 commit into from
Oct 10, 2017

Conversation

blazejkw
Copy link
Contributor

commit eba3fd18044d4cc9facec7df07930a96fbef6c3e
Author: Blazej Kwasniak kwasniakblazej@gmail.com
Date: Tue Oct 10 20:20:32 2017 +0200

Adding some unit test for LXC builder

commit 478f95ef6f527746d4a6bf285e31db2ab48e8933
Author: Blazej Kwasniak kwasniakblazej@gmail.com
Date: Tue Oct 10 20:20:07 2017 +0200

Adding support for LXC builder

Fixing #23

@blazejkw
Squashed commit of the following:
1353257 
commit eba3fd18044d4cc9facec7df07930a96fbef6c3e
Author: Blazej Kwasniak <kwasniakblazej@gmail.com>
Date:   Tue Oct 10 20:20:32 2017 +0200

    Adding some unit test for LXC builder

commit 478f95ef6f527746d4a6bf285e31db2ab48e8933
Author: Blazej Kwasniak <kwasniakblazej@gmail.com>
Date:   Tue Oct 10 20:20:07 2017 +0200

    Adding support for LXC builder

Fixing #23
@coveralls
Copy link

coveralls commented Oct 10, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 81.637% when pulling 1353257 on blazejkw:issue_23 into c8cce9a on mayn:master.

@mayn mayn added this to the 0.5.0 milestone Oct 10, 2017
mayn
mayn approved these changes Oct 10, 2017
View reviewed changes
Copy link
Owner

@mayn mayn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mayn
Copy link
Owner

mayn commented Oct 10, 2017

closing + reopen to build against python3 checks

@mayn mayn closed this Oct 10, 2017
@mayn mayn reopened this Oct 10, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 81.637% when pulling 1353257 on blazejkw:issue_23 into c8cce9a on mayn:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 81.637% when pulling 1353257 on blazejkw:issue_23 into c8cce9a on mayn:master.

@mayn mayn merged commit 29a16bd into mayn:master Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayn mayn mayn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@blazejkw @coveralls @mayn