Add listen port option for NAT routing #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayuresh82
reviewed
Mar 23, 2022
mayuresh82
reviewed
Mar 23, 2022
mayuresh82
reviewed
Mar 23, 2022
|
Thanks for the contribution @danlsgiga ! Can you please check my comments ? |
|
Good catch @mayuresh82! I realized this was not backwards compatible and would break the app for anyone using the current form of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives me the flexibility to define what listening port I want to advertise and what destination port it will route requests to.
From a Nomad perspective, this gives me the ability to run, for example, my DNS server on a dynamic port but still be able to listen on port 53 and route requests to the dynamic port.
Also add examples and enhance the README