Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow stale requests from Consul #4

Merged
merged 5 commits into from
Jan 31, 2020
Merged

Allow stale requests from Consul #4

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b129bc8
allow consul stale
chuckyz Jan 30, 2020
52a05e0
os.Getenv returns a string
chuckyz Jan 30, 2020
1001600
use url.Values and .Encode
chuckyz Jan 30, 2020
6e00028
revert using url.Values as url.Add wont work
chuckyz Jan 30, 2020
4a9df03
switch from implicit to explicit string
chuckyz Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion controller/consul.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import (

const (
consulNodeEnv = "CONSUL_NODE"
allowStale = "CONSUL_STALE"
matchTag = "enable_gocast"
nodeURL = "/catalog/node"
remoteHealthCheckurl = "/health/checks"
Expand Down Expand Up @@ -52,7 +53,11 @@ func NewConsulMon(addr string) (*ConsulMon, error) {

func (c *ConsulMon) queryServices() ([]*App, error) {
var apps []*App
addr := c.addr + fmt.Sprintf("%s/%s", nodeURL, c.node)
var stale string
if os.Getenv(allowStale) == "true" {
stale = "stale"
}
addr := c.addr + fmt.Sprintf("%s/%s?%s", nodeURL, c.node, stale)
mayuresh82 marked this conversation as resolved.
Show resolved Hide resolved
resp, err := c.client.Get(addr)
if err != nil {
return apps, err
Expand Down