Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: js to ts with fixing some missing variable #8

Merged
merged 2 commits into from
May 28, 2021

Conversation

danangekal
Copy link
Contributor

Hi @mazipan,

Ikut bantu issue #7 saya bantu sedikit rapihin ke typescript next mungkin mau bantu rapihin yg lainnya. Mohon dikoreksi klo banyak yg salah ya 🙏🏻.

Thanks.

@vercel
Copy link

vercel bot commented May 27, 2021

Someone is attempting to deploy a commit to a Personal Account owned by @mazipan on Vercel.

@mazipan first needs to authorize it.

@vercel
Copy link

vercel bot commented May 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/mazipan/ksana/H1DaiKied3HowTQfcsVXreapsmcM
✅ Preview: https://ksana-git-fork-danangekal-danangekal-rewrite-to-ts-mazipan.vercel.app

Copy link
Owner

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cukuplah ya, walaupun isinya any melulu 😂

@mazipan
Copy link
Owner

mazipan commented May 27, 2021

Error pas build btw pak @danangekal

@danangekal
Copy link
Contributor Author

Cukuplah ya, walaupun isinya any melulu 😂

Sementara biar cepet any dlu mas.. blm tau semua tipe datanya euy.. hehehe sambil jalan nnti dibuat interface/type nya.. Btw udh disolved ya yg build error. hbis itu dimerge nnti sy ambil lg buat setup pre commit nya yak...

Copy link
Owner

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build already passed with some caveats

@mazipan mazipan merged commit fb4342b into mazipan:master May 28, 2021
@mazipan mazipan mentioned this pull request May 28, 2021
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants