Enable mainfont in default.yaml #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mb21
reviewed
Feb 16, 2023
electron/pandoc/export.ts
Outdated
Comment on lines
228
to
230
| if (docMeta.mainfont === undefined) { | ||
| out.metadata.mainfont = '-apple-system, BlinkMacSystemFont, Segoe UI, sans-serif'; | ||
| out.metadata.mainfont = extMeta.mainfont || '-apple-system, BlinkMacSystemFont, Segoe UI, sans-serif'; | ||
| } |
There was a problem hiding this comment.
Thanks! that indeed seems to be bug... If I remember correctly, I added this line so that the HTML export via pandoc uses the same font as the preview. These fonts won't ever work with pdflatex... so probably the better fix would be the following?
if (docMeta.mainfont === undefined && toFormat === 'html') {
out.metadata.mainfont = '-apple-system, BlinkMacSystemFont, Segoe UI, sans-serif';
}There was a problem hiding this comment.
And maybe the background color in the following lines can also be skipped for non-HTML?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the main font to be set via
default.yamlas proposed in #131