Refactorings #57
Merged
Refactorings #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mb21
commented
Apr 3, 2021
•
mb21
commented
- upgrade from Electron 9 to 12
- Remove all uses of the deprecated Electron remote module and replace with more secure IPC implementation. This also cleanly decouples the GUI app from the code that accesses the file system, and should enable us to eventually run PanWriter in a browser as well.
- convert all PureScript files (which weren't that many) and most JavaScript files (which unfortunately had become many) to TypeScript, based on this electron template
- remove ability to read user-customizable css files (maybe we can add something like that in the future again, but will have to work with pandoc's document-css, which we'd need to parse properly)
mb21
added a commit
that referenced
this pull request
Apr 9, 2021
- upgrade from Electron 9 to 12 - Remove all uses of the deprecated Electron remote module and replace with more secure IPC implementation. This also cleanly decouples the GUI app from the code that accesses the file system, and should enable us to eventually run PanWriter in a browser as well. - convert all PureScript files (which weren't that many) and most JavaScript files (which unfortunately had become many) to TypeScript - remove ability to read user-customizable css files (maybe we can add something like that in the future again, but will have to work with pandoc's document-css, which we'd need to parse properly)
mb21
added a commit
that referenced
this pull request
Apr 9, 2021
- upgrade from Electron 9 to 12 - Remove all uses of the deprecated Electron remote module and replace with more secure IPC implementation. This also cleanly decouples the GUI app from the code that accesses the file system, and should enable us to eventually run PanWriter in a browser as well. - convert all PureScript files (which weren't that many) and most JavaScript files (which unfortunately had become many) to TypeScript - remove ability to read user-customizable css files (maybe we can add something like that in the future again, but will have to work with pandoc's document-css, which we'd need to parse properly)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.