Skip to content

[Silicon Labs] Add support for low-power async Serial #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 29 commits into from
Sep 25, 2015
Merged

[Silicon Labs] Add support for low-power async Serial #1340

merged 29 commits into from
Sep 25, 2015

Conversation

stevew817
Copy link
Contributor

  • Added support for LEUART operation down to EM2.
  • Updated license headers

stevew817 and others added 28 commits September 16, 2015 16:27
@stevew817
Merge pull request #5 from mbedmicro/master
9150189 
Update for real now.
@asmellby
branched block/unblock
5a9464b
@asmellby
set clocktrees, and enable DMA in EM2
7746a4b
@asmellby
various fixes - candidate release
b832689
@asmellby
LEUART EM2 release
f1e1977
@asmellby
DMA fix
c328fb0
@asmellby
compatability for devices without LFXO or where LFXO is not the low e…
f9c1ca8 
…nergy clock source
@asmellby
if no sleep modes are blocked, enter EM3
54e2dd0
@asmellby
increased bandrate range
1adaeb4
@asmellby
move away from using defines over cmuSelect_X
529a248
@asmellby
move away from using enum values during preprocessing
1d7d92e
@asmellby
add missing #endif in clocking.h
096733c
@asmellby
defaulting to EM4 instead of EM3
7d475ad
@asmellby
removed all usage of SIGF
d5d3ba3
@asmellby
disable character match if no character is specified
e7597d5
@asmellby
properly reset interupt flags
199fe17
@asmellby
properly disable DMA if character match is set
d9d9ea3
@asmellby
removed unneccesary function
30041b8
@asmellby
clear interupts also whem using DMA
8972fab
@asmellby
add comment
4b3a6e3
@asmellby
fix typo
5ea16a7
@asmellby
clear interupts on read_async, and properly abort when end is reached
403f16d
@asmellby
abort transfer on TXC
2af3e5d
@asmellby
fix for USART transmissions under 3 bytes long
42c5af3
@asmellby
DMA interrupt fix, and avoid potential double-unblock
de8ce50
@asmellby
change license header from mbed to silicon labs
8a7ce51
@asmellby
[EFM32] Fix bug in rtc_free_real
e8b022c
@asmellby
rtc_api: Bugfix clock selection.
ec865ea
@stevew817
Copy link
Contributor Author

@0xc0170

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2015

I am on it, got scared yesterday seeing 64 files changed 😄

0xc0170
0xc0170 reviewed Sep 24, 2015
View reviewed changes
libraries/mbed/targets/hal/TARGET_Silicon_Labs/TARGET_EFM32/serial_api.c

// Clear TX buffer
obj->serial.periph.leuart->CMD = LEUART_CMD_CLEARTX;
while(obj->serial.periph.leuart->SYNCBUSY & LEUART_SYNCBUSY_CMD);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It cleared TX, but seems to be now removed? For RX it stayed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a chip shortfall, issuing cleartx here seemed to result in erratic behavior during our testing...

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 25, 2015

LGTM.

My remarks from this review:

  • might be useful to provide more info in the commit message (for example commit stevew817@c328fb0 could provide some background for that fix)
  • if possible, send logical-feature-complete-changes via PR (easier to review, fix, integrate, test, ...).

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 25, 2015

@stevew817 Is this PR complete now?

0xc0170 added a commit that referenced this pull request Sep 25, 2015
@0xc0170
Merge pull request #1340 from stevew817/master
fe238a9 
Silicon Labs - Add support for low-power async Serial
@0xc0170 0xc0170 merged commit fe238a9 into ARMmbed:master Sep 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stevew817 @0xc0170 @asmellby