-
Notifications
You must be signed in to change notification settings - Fork 541
Korean text gets cut off #181
Comments
I did a quick test here with that text (가나다) and every character was displayed correctly. Could you provide a Plunker script showing the problem? |
You actually have to type the letters out instead of copy & pasting to see the problem. Here's the script. It's identical to your demo but just in case.. When I copy & past "가나다", it works fine. But when I actually type it into the box, the first letter gets cut off (I'm using a Mac). The first letter is not completely invisible but only a small portion of it is visible. I asked my friend to test it out on a Windows PC. Stragnely this time, no matter how long the text was, the last letter was invisible while he was typing. Of course, when enter was pressed, a perfectly good tag gets created. I don't know if this is a thing that happens only with Korean text. |
Are you using some custom CSS for the input element? |
No, the Plunker script has no css in it. And I also just noticed that Korean text with 2 characters length, such as "가나" doesn't get recognised as valid tag. I don't know if other Asian texts have the same problem. Here's a video of me entering some Korean texts on Plunker: link. |
Hi, i have similar trouble with typing russsian letter 'б', typing it triggerss special comma callback because it's code 188 is part of unicode sequence, so i added option |
There's an underlying feature that automatically re-sizes the input width as you type so all characters are visible at the same time. All I can imagine is that feature is somehow miscalculating the correct width when certain characters are typed into the input. I'll try to emulate a Korean keyboard in order to reproduce this problem. About the other issue, by default a tag must contain 3 characters in order to be deemed valid. You can change that by setting the |
Awesome. Thank you |
@deflexor That issue has been reported before. It should be addressed by #95. |
@jinarusha I've managed to emulate a Korean keyboard and succeeded in reproducing your problem. I'm converting this issue into a bug and I'll try to fix it for the next release. If you don't mind, I'd like to ping you when this is fixed so you can test it and confirm it's working. |
Great! Looking forward to the fix. Please ping me when it's available. Thank you for your awesome work. |
@jinarusha I've added a new method to the You can grab the latest build here and use the following code to test it out: app.config(function(tagsInputConfigProvider) {
tagsInputConfigProvider.setTextAutosizeThreshold(15);
}); Let me know if that solves your problem. |
@mbenford I couldn't access the files in the link you provided. So I used Grunt to build it and tried it. The fix works perfectly and it seems the problem is now fixed! I'm a newbie to angular and it's unfortunate that I was not able to contribute. Thank you for your awesome work! |
Add a new method to the tagsInputConfig service to allow the threshold used by the tagsInput directive to re-size the input element based on its content to be configured. Closes mbenford#181
While entering "가나다", the first letter ("가") is almost invisible until I press enter.
The text was updated successfully, but these errors were encountered: