Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split validateResponse into decodeResponse and validateSAMLResponse #31

Merged
merged 3 commits into from
Dec 5, 2022
Merged

Split validateResponse into decodeResponse and validateSAMLResponse #31

merged 3 commits into from
Dec 5, 2022
+21 −2

Conversation

fumieval
Copy link
Contributor

Checklist

  • All definitions are documented with Haddock-style comments.
  • All exported definitions have @since annotations.
  • Code is formatted in line with the existing code.
  • The changelog has been updated.

These are particularly useful when an application wants to peek the contents of Response in order to determine which certificate to verify with in multi-tenant usecase. They are helpful for debugging and testing too.

@github-actions github-actions bot requested a review from mbg November 15, 2022 09:10
@fumieval fumieval changed the title Split validateResponse into decodeResponse adn validateSAMLResponse Split validateResponse into decodeResponse and validateSAMLResponse Nov 16, 2022
mbg
mbg reviewed Dec 4, 2022
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, @fumieval! And sorry for the long wait on a review. Unfortunately, I didn't have much time lately and so getting around to this review took me longer than I would have liked.

CHANGELOG.md Outdated Show resolved Hide resolved
src/Network/Wai/SAML2/Validation.hs Outdated Show resolved Hide resolved
fumieval and others added 2 commits December 5, 2022 10:53
mbg
mbg approved these changes Dec 5, 2022
View reviewed changes
Copy link
Owner

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me now, thank you!

@mbg mbg merged commit f334f34 into mbg:master Dec 5, 2022
@Philonous Philonous mentioned this pull request Dec 8, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbg mbg mbg approved these changes

Assignees

@fumieval fumieval

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fumieval @mbg