Request: reduce the precision of IssueInstant to microseconds #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fumieval
force-pushed
the
request-precision
branch
from
9834346
to
f1620fc
Compare
fumieval
changed the title
mbg
reviewed
Jan 16, 2023
src/Network/Wai/SAML2/Request.hs
Outdated
| @@ -33,6 +33,7 @@ import Crypto.Random | |||
|
|
|||
| import Data.Time.Clock | |||
| import Data.Time.Format | |||
There was a problem hiding this comment.
Looks like this import might be redundant now.
fumieval
force-pushed
the
request-precision
branch
from
f1620fc
to
191fa0a
Compare
|
My pleasure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
@sinceannotations.It turns out that picosecond resolution in the
IssueInstanttimestamp causesXML attribute 'IssueInstant' in the SAML message must be a dateTime.error on AzureAD. This change fixes the problem by usingiso8601Showinstead, reducing the resolution to microseconds